search

XanaduAI / thewalrus

A library for the calculation of hafnians, Hermite polynomials and Gaussian boson sampling.
https://the-walrus.readthedocs.io
Apache License 2.0
100 stars 55 forks source link

openMP does work in MacOS #258

Closed nquesada closed 3 years ago

nquesada commented 3 years ago

Would be also good to change if things have changes in Windows. Thanks @jakeffbulmer for pointing this out.

jakeffbulmer commented 3 years ago

I think I needed to install g++ for it to work on MacOS, so I'm not sure whether it is working with Clang. I can't really remember though...

nquesada commented 3 years ago

It does work when you just install the wheels, right @jakeffbulmer ?

jakeffbulmer commented 3 years ago

oh right, yes true

josh146 commented 3 years ago

I think I originally wrote this sentence in the readme, and I think I was referring to the wheels 😆 The wheels use CLANG and unfortunately as far as I am aware, disable OpenMP during this process.

codecov[bot] commented 3 years ago

Codecov Report

Merging #258 (ec11cfb) into master (2fab865) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #258   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           21        21           
  Lines         1319      1319           
=========================================
  Hits          1319      1319

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2fab865...ec11cfb. Read the comment docs.