search

XanaduAI / thewalrus

A library for the calculation of hafnians, Hermite polynomials and Gaussian boson sampling.
https://the-walrus.readthedocs.io
Apache License 2.0
100 stars 55 forks source link

pinning down nbsphinx #260

Closed nquesada closed 3 years ago

codecov[bot] commented 3 years ago

Codecov Report

Merging #260 (84ac371) into master (a749726) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #260   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           21        21           
  Lines         1315      1315           
=========================================
  Hits          1315      1315

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a749726...84ac371. Read the comment docs.

josh146 commented 3 years ago

@nquesada I just pushed a commit that should have read the docs use Python 3.7 🤞

josh146 commented 3 years ago

@nquesada I got Sphinx building with updated requirements 👍 However, this does not seem to fix the Basic Hafnian tutorial. Maybe there is just something currently wrong with the ipynb file itself, since I looked at the other tutorials, and they all seem to be embedding their images fine?

Regardless, we should merge in these changes since it allows contributors to use a newer sphinx version.

nquesada commented 3 years ago

You just need to approve it and it is ready to merge @josh146 !