XanaduAI / thewalrus

A library for the calculation of hafnians, Hermite polynomials and Gaussian boson sampling.

https://the-walrus.readthedocs.io

Apache License 2.0

100 stars 55 forks source link

Fix build failure on M1 Macs #273

Closed brownj85 closed 3 years ago

brownj85 commented 3 years ago

Context: thewalrus will fail to build in a miniforge environment on M1 Macs. This was caused by the compiler flag that (unnecessarily) included Xcode headers, which resulted in conflicting definitions for certain math functions on M1 Macs if Xcode was installed.

Description of the Change: Removes Xcode include flag

Benefits: thewalrus now compiles in miniforge for M1 Macs.

Possible Drawbacks:

Related GitHub Issues:

255

codecov[bot] commented 3 years ago

Codecov Report

Merging #273 (71083b7) into master (a728396) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #273   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           21        21           
  Lines         1435      1435           
=========================================
  Hits          1435      1435

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a728396...71083b7. Read the comment docs.

brownj85 commented 3 years ago

So happy for this to be merged in once an M1 dev has verified it works (either @thisac or @tlubowe).

It built and passed tests on my M1, but the more people test the better

thisac commented 3 years ago

This is great! Just tested it on my M1 as well, and I seem to be able to install it without any issues (although, worth noting is that I didn't have any issues before either).

brownj85 commented 3 years ago

hey @josh146, @thisac, can you approve?

nquesada commented 3 years ago

Thanks for solving this issue @brownj85 !