search

XanaduAI / thewalrus

A library for the calculation of hafnians, Hermite polynomials and Gaussian boson sampling.
https://the-walrus.readthedocs.io
Apache License 2.0
100 stars 55 forks source link

Limit numpy version to 1.20 to prevent numba error about incompatibility with numpy #279

Closed lneuhaus closed 3 years ago

lneuhaus commented 3 years ago

Context:

Description of the Change:

Benefits:

Possible Drawbacks:

Related GitHub Issues:

josh146 commented 3 years ago

Hey @lneuhaus! Thanks for this. Instead of limiting NumPy, can we instead limit numba<0.54?

I think better to restrict Numba (a package less users might already have installed) than NumPy, to avoid potential dependency resolving issues

josh146 commented 3 years ago

Note: I've already made this change in https://github.com/XanaduAI/thewalrus/pull/278