Closed sduquemesa closed 2 years ago
@sduquemesa this is great, thanks for tackling this!
Hi @josh146 and @thisac, I believe this is ready for a first round of reviews!
Currently wheels are built for
as done before by CircleCI+Appveyor. Any arch missing?
Should I set up a continuous deployment actions as well; i.e., automatic upload of wheels on a release?
Formatting issues are addressed on PR #291
CircleCI and Appvyor fail because their configuration files were removed from this branch.
One question @sduquemesa, I can't seem to find the artifacts created by the wheel builders?
One question @sduquemesa, I can't seem to find the artifacts created by the wheel builders?
@josh146, wheels were only uploaded on master
; I have removed that condition with this commit. Now you should see the uploaded artifacts 🚀
wheels were only uploaded on master
Thanks @sduquemesa for clarifying!
I see them! Although, isn't having them only being built on master better? 🤔
I agree @thisac --- although it was my confusion that caused this, I think the original behaviour you had @sduquemesa was the correct one
Thanks @thisac and @josh146 for your comments! I think I have integrated the suggested changes. This is ready to go if there are no more comments 🚀 To merge @josh146 will have to override Circle and Appveyor tests.
Context: It might make sense to port the wheel building CI away from a combination of CircleCI/Appveyor, for a couple of reasons:
In addition, we could also set up continuous deployment; when a new GitHub release is made, the wheels could be automatically built, tested, and uploaded.
Description of the Change:
Benefits:
Possible Drawbacks: Performance -- GitHub actions might be slower than the current combination of CircleCI/Appveyor.
Related GitHub Issues: Closes #191