XanaduAI / thewalrus

A library for the calculation of hafnians, Hermite polynomials and Gaussian boson sampling.
https://the-walrus.readthedocs.io
Apache License 2.0
100 stars 55 forks source link

add workflow badges to README #294

Closed sduquemesa closed 2 years ago

sduquemesa commented 2 years ago

Context: CI (formatting checks, build and testing) was migrated from Appveyor+circleCI to github actions by PR #292. Badges of workflow statuses were not updated on the README file.

Description of the Change: This PR adds "tests" and "build" status badges to the README file. To do so, builds workflows on PR #292 were merged into a single github action.

Benefits: Status of workflows displayed on README file.

Possible Drawbacks: None

Related GitHub Issues: Port over to GitHub actions for building the wheels/continuous deployment, issue #191

codecov[bot] commented 2 years ago

Codecov Report

Merging #294 (4ec1de9) into master (bdc050f) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #294   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           21        21           
  Lines         1451      1451           
=========================================
  Hits          1451      1451           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bdc050f...4ec1de9. Read the comment docs.

sduquemesa commented 2 years ago

Thanks for catching this @sduquemesa! Just one comment before approval: don't forget to delete the old wheel actions!

I believe I did already! (see commit). The current running actions are coming from master, once merged they'll stop running.

josh146 commented 2 years ago

That's odd, the deletions are not showing up in the diff: https://github.com/XanaduAI/thewalrus/pull/294/files

Could the files have been accidentally reintroduced in a later merge?

sduquemesa commented 2 years ago

Indeed, that was the case. Thanks for spotting it. Just re-deleted the files 😅