Closed BastianZim closed 2 years ago
Hi @thisac thanks for the quick confirmation. Happy to help - "friends of mine" have made that mistake as well before...
Merging #308 (0e2c4b7) into master (28cba83) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #308 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 21 21
Lines 1456 1456
=========================================
Hits 1456 1456
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 28cba83...0e2c4b7. Read the comment docs.
Before submitting
Please complete the following checklist when submitting a PR:
[ ] All new features must include a Python unit test, C++ unit test, or both if applicable. If you've fixed a bug or added code that should be tested, add a test to the tests (C++) and thewalrus/tests directory!
[ ] All new Python and C++ code must be clearly commented and documented. Python code is documented using Napolean Google style, and C++ code is documented using Doxygen. If you do make documentation changes, make sure that the docs build and render correctly by running
make docs
.[ ] Ensure that the test suite passes, by running
make test
.[ ] Add a new entry to the
.github/CHANGELOG.md
file, summarizing the change, and including a link back to the PR.[ ] The Walrus source code conforms to PEP8 standards. We check all of our code against Pylint. To lint modified files, simply
pip install pylint
, and then runpylint pennylane/path/to/file.py
.When all the above are checked, delete everything above the dashed line and fill in the pull request template.
Context:
Description of the Change: _.DSStore is a macOS system file and should not be included.
Benefits:
Possible Drawbacks:
Related GitHub Issues: