search

XanaduAI / thewalrus

A library for the calculation of hafnians, Hermite polynomials and Gaussian boson sampling.
https://the-walrus.readthedocs.io
Apache License 2.0
99 stars 54 forks source link

Removes all remaining C++ files and implements hafnian functions in pure python using numba #311

Closed nquesada closed 2 years ago

nquesada commented 2 years ago

@thisac : there are some minor issues that are making CodeFactor unhappy. However, in the mean time, could you edit the scripts that call the bots and instruct them to not try to run C++ (since there are none) and not try to compile C++ code since, again, there is none.

codecov[bot] commented 2 years ago

Codecov Report

Merging #311 (ffed942) into master (90db66a) will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #311   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           22        22           
  Lines         1469      1561   +92     
=========================================
+ Hits          1469      1561   +92
Impacted Files Coverage Δ
thewalrus/__init__.py 100.00% <ø> (ø)
thewalrus/csamples.py 100.00% <ø> (ø)
thewalrus/quantum/__init__.py 100.00% <ø> (ø)
thewalrus/random.py 100.00% <ø> (ø)
thewalrus/reference.py 100.00% <ø> (ø)
thewalrus/samples.py 100.00% <ø> (ø)
thewalrus/symplectic.py 100.00% <ø> (ø)
thewalrus/_hafnian.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 90db66a...ffed942. Read the comment docs.

josh146 commented 2 years ago

😍

My only comment is that the name of this page in the docs https://hafnian--311.org.readthedocs.build/en/311/code/thewalrus.html probably doesn't make any sense any more, since the entire library is now Python?