Closed fab1an-q closed 2 years ago
Merging #322 (cb30e94) into master (7f56333) will not change coverage. The diff coverage is
100.00%
.
@@ Coverage Diff @@
## master #322 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 23 24 +1
Lines 1644 1697 +53
=========================================
+ Hits 1644 1697 +53
Impacted Files | Coverage Δ | |
---|---|---|
thewalrus/decompositions.py | 100.00% <100.00%> (ø) |
|
thewalrus/quantum/__init__.py | 100.00% <100.00%> (ø) |
|
thewalrus/quantum/entanglement.py | 100.00% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 7f56333...cb30e94. Read the comment docs.
This is a great addition @fab1an-q ! Three minor comments:
black -l 100
to all the files in the PRpytest
here:Also @fab1an-q don't forget to update the ACKNOWLEDGEMENTS and CHANGELOG. It is awesome to have you as a contributor to the mightiest marine mammal!
Should we wait for more approvals, or is this ready to be merged?
Assuming the changes in files like docs/_ext/edit_on_github.py
are intentional, then this is ready to go. @thisac
Context: We want to equip TW with entanglement measures for Gaussian states.
Description of the Change: There are two new entanglement measures implemented: entanglement entropy (only for pure states) and logarithmic negativity (for pure and mixed states). With a given covariance matrix
cov
, these can be obtained bywhere
modes_A
is the subset of modes that defines the bipartition. Alternatively, the kwargmodes_A
can be replaced bysplit
, an integer which defines at which mode index the state is divided into two substates.Benefits: Quantify entanglement of pure and mixed states along arbitrary bipartitions.
Possible Drawbacks: None
Related GitHub Issues: None