search

XanaduAI / thewalrus

A library for the calculation of hafnians, Hermite polynomials and Gaussian boson sampling.
https://the-walrus.readthedocs.io
Apache License 2.0
99 stars 54 forks source link

Adding probability tests #368

Closed nquesada closed 8 months ago

nquesada commented 1 year ago

Adds non-batched internal modes calculation of probabilities.

codecov[bot] commented 1 year ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (internal_modes@ece2cb4). Click here to learn what that means. The diff coverage is n/a.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## internal_modes #368 +/- ## ================================================= Coverage ? 94.07% ================================================= Files ? 32 Lines ? 2262 Branches ? 0 ================================================= Hits ? 2128 Misses ? 134 Partials ? 0 ``` ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/XanaduAI/thewalrus/pull/368?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XanaduAI). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XanaduAI) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/XanaduAI/thewalrus/pull/368?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XanaduAI). Last update [ece2cb4...07faa97](https://app.codecov.io/gh/XanaduAI/thewalrus/pull/368?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XanaduAI). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XanaduAI).
DavidSPhillips commented 11 months ago

After the docstring change all tests pass? It was test_pure_gkp that was failing, is it just a by chance numerical thing?

DavidSPhillips commented 11 months ago

After the docstring change all tests pass? It was test_pure_gkp that was failing, is it just a by chance numerical thing?

The tests from this branch are still failing on wsl my laptop (with numba=0.55.1), but I re-run the jobs here and it's still passing.

nquesada commented 8 months ago

@rachelchadwick is this good to be merged?