search

XanaduAI / thewalrus

A library for the calculation of hafnians, Hermite polynomials and Gaussian boson sampling.
https://the-walrus.readthedocs.io
Apache License 2.0
99 stars 54 forks source link

Implements the pre-Iwasawa and Iwasawa decompositions. #382

Closed nquesada closed 4 months ago

nquesada commented 5 months ago

Adds the Iwazawa and pre-Iwazawa decompositions. See page 15 of https://arxiv.org/pdf/quant-ph/9509002.pdf

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (8759363) to head (5c12015).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #382 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 28 28 Lines 1956 1996 +40 ========================================= + Hits 1956 1996 +40 ``` | [Files](https://app.codecov.io/gh/XanaduAI/thewalrus/pull/382?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XanaduAI) | Coverage Δ | | |---|---|---| | [thewalrus/decompositions.py](https://app.codecov.io/gh/XanaduAI/thewalrus/pull/382?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XanaduAI#diff-dGhld2FscnVzL2RlY29tcG9zaXRpb25zLnB5) | `100.00% <100.00%> (ø)` | | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/XanaduAI/thewalrus/pull/382?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XanaduAI). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XanaduAI) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/XanaduAI/thewalrus/pull/382?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XanaduAI). Last update [8759363...5c12015](https://app.codecov.io/gh/XanaduAI/thewalrus/pull/382?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XanaduAI). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=XanaduAI).
nquesada commented 4 months ago

Sorry for the hiccup, there was no bug... just my lack of consistent understanding of this decompositions. All good to go!

No worries @sduquemesa your expert eye and careful reviewing is always appreciated!