Xanashi / Icaros

Official issue tracker and download location for Icaros Shell Extensions
690 stars 8 forks source link

[Feature Request] SVG Support #17

Open CrackHub opened 4 years ago

CrackHub commented 4 years ago

Can you support svg files? I don't wanna install any other app for this. Thanks.

Xanashi commented 4 years ago

SVG support is something I personally would love to see in Icaros as well, as I work with SVG files every day. However FFmpeg requires the third party library librsvg, which in addition requires several other libraries, to render SVG files.

I'm trying to avoid having too many libraries in Icaros, to keep it as lightweight as possible, so I'm currently considering other possibilities for adding SVG support.

Bottomline is, it's on my todo list!

ElizTriad commented 3 years ago

for SVG files I use https://github.com/tibold/svg-explorer-extension also use https://github.com/Agamnentzar/psd-thumbnail-provider for psg files

Destroy666x commented 1 year ago

If you don't want to bundle additional libraries, perhaps allow users to link to their ffmpeg, e.g. I'm using ffmpeg-full on all Windows installs. Assuming the version required by and bundled with Icaros isn't too outdated.

Xanashi commented 1 year ago

I mentioned this in another github issue, so I'm going to take my reply from there: Loading FFmpeg dynamically is a very daunting task, with lots of potential complications including security/malware, debugging, instability and so on. It's just not viable.

The version of FFmpeg included in Icaros is very up-to-date, it just doesn't include too many additional libraries. With all that said I am working on SVG support right now, so stay tuned!

Destroy666x commented 1 year ago

Daunting - maybe, depends on how the app is coded.

Security/malware risks - I don't think so, if implemented any properly. Bunch of popular apps written in various languages allow that. To name a few: ShareX, Krita, Audacity.

Xanashi commented 1 year ago

Icaros is loaded automatically by Explorer every time a file requires a thumbnail for any filetype supported by Icaros. Say someone distributed Icaros with a version of FFmpeg that they've modded with malicious code, any user that installed their distribution would very like trigger this malicious code right away, the second they enabled thumbnailing. All with my frontend and app brand.

Destroy666x commented 1 year ago

I see your point but not sure I agree with that. E.g. they could also bundle Icaros installer + some virus install right now, if they really want to. It's not as "easy" perhaps, but it happens regularly with e.g. pirated software distributed through torrents. Whether it's really well disguised or just "Open that other .exe to crack the software" or in this case "Open that other (clearly a plugin) .exe to gain extra benefits, such as .svg preview".

neoOpus commented 1 year ago

It is better to use MS PowerToys for this

image

fossist commented 9 months ago

It is better to use MS PowerToys for this

PowerToys is a very huge package just for SVG. Most tools in PowerToys are useless and can be replaced by 3rd party tools which are better and not cpu heavy.

Inclusion of SVG in icaros will be a huge update.

Xanashi commented 9 months ago

I'm working on it right now, I just don't have an ETA for when it will be ready. 👍

yw4z commented 6 months ago

is there any progress on this. thanks for your efforts

Xanashi commented 6 months ago

I'm currently a bit overwhelmed by work and other IRL things, but SVG is still the top priority for me to get included, besides bug fixes. So I am actively working on it whenever I have the time.

yw4z commented 6 months ago

not in hurry. just wondered status. thanks for your all efforts