Xanashi / Icaros

Official issue tracker and download location for Icaros Shell Extensions
621 stars 7 forks source link

[BUG] cover not displayed unless MIME type is "image/jpeg" #42

Closed mjolnir870 closed 1 year ago

mjolnir870 commented 1 year ago

If an mkv has a cover attachment of type image/webp and cover.webp, Icaros doesn't use it for the thumbnail. If the MIME type is changed to image/jpeg, then Icaros correctly uses it as the cover. Can Icaros add support for covers with MIME types other than image/jpeg?

image

In the zip are samples of a video with an embedded webp cover (MIME type image/webp), and then two copies, one with MIME type image/jpeg (correctly thumbnailed) and one with MIME type image/jpg (no thumbnail). The raw webp thumbnail is also included.

samples.zip

Xanashi commented 1 year ago

Hi mjolnir870,

This is definitely a problem. I'll make sure it's fixed in the upcoming release. Thank you for the samples! Really helps me fixing the issue much faster.

mjolnir870 commented 1 year ago

This is definitely a problem. I'll make sure it's fixed in the upcoming release. Thank you for the samples! Really helps me fixing the issue much faster.

Thanks in advance for the fix! I didn't think about it when making samples but image/png should probably be handled as well.

Xanashi commented 1 year ago

image/png should already be supported in the current version of Icaros 👍

Xanashi commented 1 year ago

Hi mjolnir870,

This should be fixed in the latest beta release. Please try it out! Find 3.3.1 Beta 1 HERE