Xanashi / Icaros

Official issue tracker and download location for Icaros Shell Extensions
621 stars 7 forks source link

Changing language does not change language of properties #97

Closed LesFerch closed 3 months ago

LesFerch commented 3 months ago

Currently, property labels are always English:

Icaros.AudioTracks         Audio tracks
Icaros.BitDepth            Bit depth
Icaros.ContainsChapters    Contains chapters
Icaros.ContentCompression  Content compression
Icaros.SubtitleGroup       Subtitles
Icaros.SubtitleTracks      Subtitle tracks
Icaros.VideoTracks         Video tracks

With Icaros set to German, I would expect to see something like this:

Icaros.AudioTracks         Audiospuren
Icaros.BitDepth            Bittiefe
Icaros.ContainsChapters    Enthält Kapitel
Icaros.ContentCompression  Inhaltskomprimierung
Icaros.SubtitleGroup       Untertitel
Icaros.SubtitleTracks      Untertitelspuren
Icaros.VideoTracks         Videospuren

Note: I only speak English. The above is machine translated.

Xanashi commented 3 months ago

Hi, You need to click the checkbox that appears under the combobox where you set the language in IcarosConfig to change the localization of the properties in Explorer.

LesFerch commented 3 months ago

Thank you!

I see why I missed that option. When the language is English, the option is not shown: image When the language is changed, the option appears, but, because I only speak English, it didn't catch my attention: image

Why would anyone change to a language they don't speak? Testing. Setting the configuration for someone else. Checking the integration with another program.

My suggestion is to always show the option and have it checked by default. It can be greyed out for English: image

Xanashi commented 3 months ago

Being able to set the language is fairly common practice in all software. Always give users the option, you can't anticipate their circumstances or preferences. As an example, my native language is not English, but I always prefer all my software to be set to English.

The reason why I hide the checkbox when English is selected, is because the option simply isn't available in English, and if I greyed out the checkbox, users would just start asking why that option is never available/clickable instead. And then someone would tell me to "just remove it, if it's not an actual option".

LesFerch commented 3 months ago

Good point about the greyed out option, but I would still argue for the default to be checked. Not a big deal though.

Xanashi commented 3 months ago

And that is a good point. I definitely think it makes sense to make enabled by default, if the OS language is set to the same language as the one selected in Icaros.