search

Xandaros / evolve

An advanced admin mod for Garry's Mod
49 stars 39 forks source link

Further patching of "Cbuf_AddText: buffer overflow" error. #180

Closed bellum128 closed 2 years ago

bellum128 commented 2 years ago

Additional patching for #99 , as buffer overflow issue began manifesting again as our ban list approached 400 players. Removed the for loop that vanilla bans on start, and rewrote to vanilla ban to occur on CheckPassword hook per player as they join.

bellum128 commented 2 years ago

Currently testing the fix on our server for a bit.

bellum128 commented 2 years ago

Fix looks good after testing.

bellum128 commented 2 years ago

Some additional information on the initial issue, the buffer overflow at this location was causing players to not be flagged as banned, so banned players were able to join due to the overflow.