Closed halkeye closed 5 years ago
So I don't know why the dockercloud builds are failing, but I think its because miniredis changed its urls to include /v2 at the end, but glide seems to fail no matter what i do
Ah, need to pin a release - https://github.com/alicebob/miniredis/issues/78
This looks good but shouldn't a postgres instance outside the container have a password? I don't have much experience with PG but I know with mysql you'd usually configure a user and password for your app. LMK if I'm totally off base here.
I think panicking in the case of missing users is fair. There isn't much we can do to improve the user experience for an app that silently accepts webhooks behind the scenes. At least when we 4-500 something shows up in Plex's logs (not that anyone checks those but oh well).
I can't find the actual docs where I found it (should have saved it), but it supports a connection url
https://github.com/go-pg/pg/blob/a08a30ca8863774c082727a617901d3bddb44052/options_test.go#L24
If you have some suggestions on how to add it to the readme, I'll find the link tonight and update the docs
Sorry to take so long to get back to you! I've got an injury that's put me out of commission for the most part. If this is ready to merge I'm happy to merge it! Just let me know.
Oh nos. That bites. Sorry to hear that.
Yea I've been running it for a bit. It's good to go. There's no docs though.
then a docker deploy when its done?
\o/\o/\o/
Only barely tested, wanted to get the PR up to get feedback. Especially what should happen if a user id is not found (right now I panic, but i'm not sure what proper behavior should be).