search

Xasin / HomeAutomation

General repository for all sorts of IoT and Home-Automation related projects, ESP/NodeMCU and Arduino sketches, etc.
GNU General Public License v3.0
0 stars 0 forks source link

Class Splitup merge PR #1

Closed Xasin closed 7 years ago

Xasin commented 7 years ago

Since most of the code was successfully transferred into a more usable, class-based state, here now the PR to fix that! :3

This change is Reviewable

Xasin commented 7 years ago

Reviewed 1 of 7 files at r1, 3 of 8 files at r2, 2 of 3 files at r3, 5 of 5 files at r4. Review status: 8 of 11 files reviewed at latest revision, 2 unresolved discussions.

Projects/HomeSweetHome/Hooks/MDistHook.rb, line 8 at r4 (raw file):


  @telegramMEndpoint = Messaging::Endpoint.new() do |data|
      if(data[:single] and data[:gid] and @telegramGIDTable[data[:gid]]) then

This should also be checking for "single", and only delete other messages marked with it.

Projects/HomeSweetHome/RoomLight/ColorSpeak.rb, line 47 at r4 (raw file):

      end

      @mqtt.subscribe_to "Room/#{@RoomName}/Commands" do |tList, data|

These should definitely be moved out of here, just so that the class itself doesn't do random things with the "Commands" channel.

Comments from Reviewable

Xasin commented 7 years ago

Reviewed 3 of 3 files at r5. Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable