search

Xav83 / chocolatey-packages

Implementation of the template to create and maintain chocolatey packages both manual and automatic (mostly automatic)
https://chocolatey.org/profiles/Xav83
Apache License 2.0
4 stars 4 forks source link

Updates FanFicFare to Add Plugin to Calibre #25

Closed JPRuskin closed 1 year ago

JPRuskin commented 1 year ago

This should solve the issue mentioned in the CCR moderation queue.

I quickly tested install and uninstall; It seems to add and remove from Calibre properly.

As the files seem to be imported into Calibre's working directories, we could clean up the downloaded zip at the end - but it's not large, so this probably isn't a worry.

We could also consider adding a Calibre dependency to the package? I don't know if anyone would potentially use this package to just download the files. If so, I've changed the structure of the tools directory in this PR - but felt as it currently didn't have any approved versions, this would be alright.

Xav83 commented 1 year ago

Thanks a lot @JPRuskin for your contribution ! This will help a lot for the validation of this package :pray:

Xav83 commented 1 year ago

FYI @JPRuskin, chocolatey validation process has found some issues with this new version of the FanFicFare package Screenshot from 2023-05-23 23-32-13

JPRuskin commented 1 year ago

Well, heck. I'll try and get that sorted out tomorrow.