search

Xav83 / chocolatey-packages

Implementation of the template to create and maintain chocolatey packages both manual and automatic (mostly automatic)
https://chocolatey.org/profiles/Xav83
Apache License 2.0
4 stars 4 forks source link

choco install bizhawk downloads Linux version #4

Closed Patrick-1994- closed 3 years ago

Patrick-1994- commented 3 years ago

I suppose the problem is here: https://github.com/Xav83/chocolatey-packages/blob/70cadbd22c0aa59dd909e925655a79cad78134fa/automatic/bizhawk/update.ps1#L18 The linux download is apparently relatively new. Edit: Well, rather, here: $re = "BizHawk-.+.zip$"

this works: PS C:\Users\patri> $re = "BizHawk-.+win.+.zip$" PS C:\Users\patri> $download_page.links | ? href -match $re | Select -First 1 -expand href /TASVideos/BizHawk/releases/download/2.6.1/BizHawk-2.6.1-win-x64.zip

Xav83 commented 3 years ago

Thank you @Patrick-1994- for this issue, and for the solution you proposed 🙂👍

I am going to look at it either today or tomorrow (depending on when I will have the time), and come back to you once I will have tested the Bizawk chocolatey package on my machine.

Xav83 commented 3 years ago

@Patrick-1994- Indeed, I looked at the correction you proposed and, your solution is right 🙂👍

I have pushed the solution on the develop branch, so that the next release of BitHawk will have the right package attached to it in Chocolatey.

For now, the Chocolatey package available on Chocolatey server is still the linux one. I am going to check how I can correct that.

I'll get back to you when I will have some more information about that 😉

Xav83 commented 3 years ago

Hi again @Patrick-1994- ! 🙂

I have been experimenting with Chocolatey and AU to push the BizHawk package again even if a package of the same version already exists on Chocolatey server, and I finally succeed to do it 🍾 At the moment the package is passing through the validation of Chocolatey, and you can follow it here.

Hopefully everything will be right and a working package will be soon accessible to everyone 😉

Xav83 commented 3 years ago

@Patrick-1994-

The Chocolatey package of Bizhawk has been update and should now contain the right executable for Windows !

If you have any trouble with this new package, do not hesitate to notify me about it 😉 And if everything works fine with this new package on your machine, you can also update this issue, so that I can close it, and validate that it works again, for everyone 🙂

Patrick-1994- commented 3 years ago

Fixed, thanks.

Extracting C:\Users\patri\AppData\Local\Temp\chocolatey\bizhawk\2.6.1.20210301\BizHawk-2.6.1-win-x64.zip to C:\ProgramData\chocolatey\lib\bizhawk\tools... C:\ProgramData\chocolatey\lib\bizhawk\tools ShimGen has successfully created a shim for DiscoHawk.exe ShimGen has successfully created a shim for EmuHawk.exe The install of bizhawk was successful. Software installed to 'C:\ProgramData\chocolatey\lib\bizhawk\tools'