XavRsl / Cas

CAS server SSO authentication in Laravel 4.x & 5.x
MIT License
77 stars 36 forks source link

checkAuthenticate() need to return value #43

Closed wu-yuanhui closed 6 years ago

wu-yuanhui commented 6 years ago

Hello, my english is very pool, please understand.

In Cas/src/Xavrsl/Cas/Sso.php near line 161, there is a method named checkAuthenticate(), it call the phpCAS::checkAuthentication() method, and the phpCAS::checkAuthentication() will return true or false. So, i think Sso need to return the value too. Like this:

···php

public function checkAuthenticate()
{
    if($this->isPretending()) return true;
    try
    {
        // phpCAS::checkAuthentication();                        <====this line need to return value.
        return phpCAS::checkAuthentication();
    }
    catch(\Exception $e)
    {
        throw new CasAuthenticationException;
    }
}


Please fix it as soon as possible, thinks, thinks, thinks.
XavRsl commented 6 years ago

I haven't used that package for a while and it's not really maintained anymore... I encourage you to use https://github.com/subfission/cas instead as it is originally a fork of my package but maintained.

Sorry.

Xavier