search

XavRsl / Cas

CAS server SSO authentication in Laravel 4.x & 5.x
MIT License
77 stars 36 forks source link

Refactor SSO #5

Closed eseyden closed 10 years ago

eseyden commented 10 years ago

I needed to be able to check username and if log-in without forcing a log-in,

Also I didn't see why the phpCAS init needed to be used as a singleton instead of just in the constructor.

eseyden commented 10 years ago

I think i need to do some more work to get phpCAS pulling from a stable composer repo. Possibly https://packagist.org/packages/intouch/phpcas

XavRsl commented 10 years ago

Hi ! Thanks for your work. That package needed some attention as I haven't spent enough time on it lately. It was originally built for laravel 3 and I just updated it for laravel 4 without much refactoring. So your work on moving stuff around will make the whole code a lot cleaner and more readable. Don't really know why I've used a singleton... I was probably in the process of learning design patterns at that time... Anyway, I also like the fact of havin' a stable phpcas package, but just didn't know one existed. I'll merge your changes and make a release.

Thanks again.

Xavier