XavRsl / Cas

CAS server SSO authentication in Laravel 4.x & 5.x
MIT License
77 stars 36 forks source link

CA Cert Bugfix when detecting authentication #6

Closed eseyden closed 10 years ago

eseyden commented 10 years ago

It looks like I left a bug in the pull request after some troubleshooting yesterday; I'm just not used to auto updating pull requests. Will push experimental changes to a branch from now on.

Thanks so much for merging my work upstream and the really clean CAS implementation to work with.

XavRsl commented 10 years ago

We still have a major problem. I've tried to use the package with the version of phpCAS that you inserted, but it is just not required by any classpath mechanism. So we get a fatal error : Class 'phpCAS' not found. I've tried to use another package that was supposed to be stable and called by composer, but it doesn't seem to work. Could you try to update your installation with version 1.1.1 of xavrsl/cas ? Try not to have an already installed phpCAS package in your path (like pear).

Thanks.

Xavier

eseyden commented 10 years ago

I removed the php-pear-CAS from my dev box and it looks like it still works, Maybe give composer update another shot. The autoload_classmap.php file in my vendor/composer/ contains 'phpCAS' => $vendorDir . '/rmitvn/jasig-phpcas/source/CAS.php' using the 1.1.1 version

eseyden commented 10 years ago

Also try composer dump-autoload, it may still be trying to autoload the jasig version

tyler43636 commented 10 years ago

The autoload on @eseyden repo is working fine for me too.

eseyden commented 10 years ago

Still working on debugging some issues with this pull request. Having trouble with log-out this afternoon.

XavRsl commented 10 years ago

The autoload on your installation is working as you are also using rmitvn/jasig-phpcas package. intouch/phpcas was just not loading any classpath in it's composer.json : https://github.com/In-Touch/phpCAS/blob/master/composer.json

I've tried dumpautoload a couple of times but it seems like my composer fails for some reason, it probably has nothing to do with our package. I'll look into it if I get some time.

Thanks for your update, I'll try to make a new release rapidly.

Xavier

2014-07-01 16:47 GMT+02:00 tyler43636 notifications@github.com:

The autoload on @eseyden https://github.com/eseyden repo is working fine for me too.

— Reply to this email directly or view it on GitHub https://github.com/XavRsl/Cas/pull/6#issuecomment-47665174.

Xavier

eseyden commented 10 years ago

Yep I just duplicated it, the intouch/phpcas dosen't have a class map section in the composer.json it looks like the rmitvn/jasig-phpcas isn't actually 1.3.2 but dev-master as I'm getting a bug in the logout function.

eseyden commented 10 years ago

OK, I've given up on using composer for getting phpCAS, sorry about the trouble, I thought it would work out better. Will just have to rely on pear installing the dependency outside of the scope of composer.

Looks like we will just have to wait for this issue to be fixed. https://github.com/Jasig/phpCAS/issues/78

eseyden commented 10 years ago

Sorry if I'm being too much trouble. Thanks so much for all your work on this. Unfortunately the version of phpCAS that is currently being autoloaded causes an error when I try and use the logout function. I don't think there is currently a stable way to get phpCAS 1.3.2 from composer. For now I changed it to just require_once('CAS.php') instead of using composer.

XavRsl commented 10 years ago

No problem at all ! It's maybe not a so bad idea to stick with that until jasig/phpcas makes the effort of synchronizing packagist with their releases. I really don't understand why they don't do it as it's really a non issue. We should actually fork their repo and change just what is needed to make it work... I'll might do this tomorrow. !

Xavier

Le 3 juil. 2014 à 22:38, Eric Seyden notifications@github.com a écrit :

Sorry if I'm being too much trouble. Thanks so much for all your work on this. Unfortunately the version of phpCAS that is currently being autoloaded causes an error when I try and use the logout function. I don't think there is currently a stable way to get phpCAS 1.3.2 from composer. For now I changed it to just require_once('CAS.php') instead of using composer.

— Reply to this email directly or view it on GitHub.

eseyden commented 10 years ago

Looks like pull request #7 got this fixed.