search

XavRsl / Cas

CAS server SSO authentication in Laravel 4.x & 5.x
MIT License
77 stars 36 forks source link

Fix for #7 - problem with initializing CAS #8

Closed pies closed 10 years ago

pies commented 10 years ago

This fixes #7 which causes: phpCAS error: phpCAS::isAuthenticated(): one of the methods phpCAS::setCasServerCACert() or phpCAS::setNoCasServerValidation() must be called. in ........../vendor/xavrsl/cas/src/Xavrsl/Cas/Sso.php on line 199

In short, you need to configure SSL validation before attempting to detect_authentication.

XavRsl commented 10 years ago

Thanks Pies ! Sorry for the late answer, I just have too many holidays.... :) The more I see this repo the more I'm confused about how to test it. I'm struggling with the fact that to be sure the pull requests are working I need a functional CAS server fully configured, which I don't always have at hand. Moreover, the code is simple but the process of updating it is complicated. In fact, to be fair, I kind of always accept pull requests and pray for it to work. BAD!!!! So anyway, I'll do that for the time being, please let me know if there is anything going wrong. I won't make a release just now, I'll wait for some time to refactor a little bit.

Thanks.

Xavier

pies commented 10 years ago

Thanks :) And thank you for the effort, we'll certainly keep using the lib and push back any fixes we make.

pies commented 10 years ago

I've tested the patch and it worked correctly, as expected. I would be very grateful if you could tag a release sometime relatively soon, because I really don't like to depend on dev-master (i.e. something that could change).

XavRsl commented 10 years ago

You should be good to go : https://github.com/XavRsl/Cas/releases/tag/v1.1.2

Xavier

pies commented 10 years ago

Oh, thanks, I haven't notices the release :)

eseyden commented 10 years ago

Nice work! Thanks for the new release.