Add support for avalonia (.axaml files)

Xavalon / XamlStyler

Visual Studio extension to help format your XAML source code

Apache License 2.0

1.21k stars 130 forks source link

Add support for avalonia (.axaml files) #321

Closed chkr1011 closed 2 years ago

chkr1011 commented 3 years ago

Description:

Fixes #320, #300

Add .axaml files to the document type checking.

Checklist:

[x] I have commented my code, particularly in hard-to-understand areas
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[ ] I have tested my changes by running the extension in VS2017
[x] I have tested my changes by running the extension in VS2019
[x] If changes to the documentation are needed, I have noted this in the description above

grochocki commented 3 years ago

Thanks for the PR! There are some implementation details about how we want to approach .axaml file support in #300. Would it be possible to update your PR with those changes?

chkr1011 commented 3 years ago

@grochocki Sure I will update the PR. From what I read the only currently important thing is that the "Selector" attribute should allow the character ">". If there is more to it please let me know.

I will add some "LanguageContext" which will contain information about these escaping stuff per supported language/framework like described in #302.

chkr1011 commented 3 years ago

@grochocki I added the ability to get some XAML dialect specific options when checking the affected file. Now the > is no longer escaped when an Avalonia file is formatted. I still need to refactor the code a bit but let me know if this is the right way in general.

Nickelony commented 3 years ago

Is this still being worked on?

Mikolaytis commented 3 years ago

any update on a PR? We are really need an avalonia support!

Mikolaytis commented 3 years ago

XamlStyler.Extension.Windows.vsix.zip here is VS2019 build of this fork. I've tried. it works. I'm happy now

also here is VS2022 revision: XamlStyler.Extension.Windows.VS2022.vsix.zip

chkr1011 commented 3 years ago

I am basically done with my work. I am still waiting for feedback regarding code style etc.

NicoVermeir commented 2 years ago

@maxkatz6 thanks for helping the review from the Avaolonia side of things, greatly appreciated! @chkr1011 sorry for the (very) long wait, we have looked over your PR and it looks good! just 2 things:

could you add unit tests to the PR?
Can you confirm that this is working in VS2022 as well?

thanks again for your contribution! I'm confident we can merge this in fast