Target to net 7 and 8 in addition to 6

Xavalon / XamlStyler

Visual Studio extension to help format your XAML source code

Apache License 2.0

1.2k stars 130 forks source link

Target to net 7 and 8 in addition to 6 #419

Open virzak opened 1 year ago

virzak commented 1 year ago

Description:

Fixes # (issue)

Checklist:

[x] I have commented my code, particularly in hard-to-understand areas
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[ ] I have tested my changes by running the extension in VS2017
[x] I have tested my changes by running the extension in VS2019
[x] I have tested my changes by running the extension in VS2022
[x] If changes to the documentation are needed, I have noted this in the description above

grochocki commented 1 year ago

/azp run

azure-pipelines[bot] commented 1 year ago

Azure Pipelines successfully started running 1 pipeline(s).

hansmbakker commented 9 months ago

Given that .NET 7 goes out of support on May 14, 2024, I'd suggest adding only .NET 8 instead of 7 and 8.

Other than that, great that you're contributing this!

hansmbakker commented 9 months ago

@grochocki having .NET 8 support would really be a welcome update, so that users are not forced to install .NET 6 to run the XamlStyler CLI.

Would it be an idea to do the targetframework update to .NET 8 independent of the other changes in this PR (dependency to Newtonsoft.Json, change in VS SDK version, allowPrerelease in global.json), to unblock this?

(In the meantime, I can add a .NET 8 version of the CLI to my private nuget feed as a workaround)

heartacker commented 7 months ago

hi，all，can any body tell that what block this, thanks

MarkPflug commented 4 months ago

Instead of multi-targeting, I'd suggest adding a <RollForward>Major to the xstyle .csproj. This would allow you to continue to build against a single framework version (6.0), but allow the tool to run on future versions without needing to be updated.

https://learn.microsoft.com/en-us/dotnet/core/versions/selection#control-roll-forward-behavior

nietras commented 3 months ago

We have seen the same issue with XamlStyler and think it would be great if RollForward Major was supported as @MarkPflug mentions.

virzak commented 3 months ago

Instead of multi-targeting, I'd suggest adding a <RollForward>Major to the xstyle .csproj. This would allow you to continue to build against a single framework version (6.0), but allow the tool to run on future versions without needing to be updated.

https://learn.microsoft.com/en-us/dotnet/core/versions/selection#control-roll-forward-behavior

@MarkPflug That works too. @grochocki what's your opinion?

heartacker commented 2 months ago

anyupdate?

Jeanjean commented 5 days ago

What can we do to get this MR completed?