search

Xavalon / XamlStyler

Visual Studio extension to help format your XAML source code
Apache License 2.0
1.17k stars 128 forks source link

Incompatible with Rider EAP #469

Closed bcaceiro closed 4 months ago

bcaceiro commented 6 months ago

Describe the bug Cannot use this plugin on Rider EAP - this build is incompatible : requires IDE Build 233.* or earlier

To Reproduce

Expected behavior Be compatible with rider EAP

bagusnl commented 5 months ago

just a heads up, Rider has now updated their stable to 2024.1, breaking Xaml Styler for stable users

kovrom commented 4 months ago

Hopefully pull #484 will be merged soon

grochocki commented 4 months ago

The change in #484 is not complete. If there are folks more familiar with Rider IDE, I could use some help in getting this PR ready.

kovrom commented 4 months ago

The change in #484 is not complete. If there are folks more familiar with Rider IDE, I could use some help in getting this PR ready.

Sadly I'm not familiar with plugin development for Rider IDE. But changing SdkVersion 2024.1.0-rc01 to the latest 2024.1.0 in your PR seems to build and install fine locally, without complaints from gradlew.bat

grochocki commented 4 months ago

Ah, 2024.1.0 wasn't available when I started working on this, and couldn't get 2024.1.0-rc01 to work. @kovrom could you help verify this build in Rider?

kovrom commented 4 months ago

Ah, 2024.1.0 wasn't available when I started working on this, and couldn't get 2024.1.0-rc01 to work. @kovrom could you help verify this build in Rider?

Seems to be working fine :+1:

grochocki commented 4 months ago

Submitted 3.2404.4 update to JetBrains!