Feature/arm

[28mpetrino]

Changes:

This runs the arm, claw, and claw pivot.

Controls and Usage:

View the code for the controls.

Reviewers:

@XaverianTeamRobotics/senior-programmers

[MatthewL246]

@michaell4438 Should this be moved into a feature before merging? (Same with #583)

[michaell4438]

@michaell4438 Should this be moved into a feature before merging? (Same with #583)

Probably.

[MatthewL246]

Whoops both at the same time

[michaell4438]

https://robotics.xbhs.net/getting-started/Features

[28mpetrino]

Yes, Michael told me about this and it is being changed. Thanks, Marco Petrino

On Wed, Nov 15, 2023 at 5:09 PM Matthew Lopez @.***> wrote:

@.**** commented on this pull request.

In TeamCode/src/main/java/org/firstinspires/ftc/teamcode/opmodes/ArmClaw.java https://github.com/XaverianTeamRobotics/FtcRobotController/pull/582#discussion_r1394887846 :

@@ -0,0 +1,68 @@ +package org.firstinspires.ftc.teamcode.opmodes; + +import static org.firstinspires.ftc.teamcode.internals.hardware.Devices.motor2; +import static org.firstinspires.ftc.teamcode.internals.hardware.Devices.servo0;//this is the left grabber +import static org.firstinspires.ftc.teamcode.internals.hardware.Devices.servo1;//this is the right grabber +import static org.firstinspires.ftc.teamcode.internals.hardware.Devices.servo2;//this is the servo for the claw mechanism + +import org.firstinspires.ftc.teamcode.internals.hardware.Devices;//our two devices our the motors for the arm +import org.firstinspires.ftc.teamcode.internals.registration.OperationMode; +import org.firstinspires.ftc.teamcode.internals.registration.TeleOperation; + +public class ArmClaw extends OperationMode implements TeleOperation {

It's better to use the feature inside this opmode instead of copying the code.

— Reply to this email directly, view it on GitHub https://github.com/XaverianTeamRobotics/FtcRobotController/pull/582#pullrequestreview-1733097974, or unsubscribe https://github.com/notifications/unsubscribe-auth/A43QMUCQI54D5UYZK5EAQETYEU4QJAVCNFSM6AAAAAA7NCXW3CVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTOMZTGA4TOOJXGQ . You are receiving this because you authored the thread.Message ID: @.*** .com>

[MatthewL246]

@michaell4438 You can just click "Resolve conversation" instead of deleting my review.

[michaell4438]

@michaell4438 You can just click "Resolve conversation" instead of deleting my review.

I still left you as reviewer, i just deleted a redundant comment

[michaell4438]

@28mpetrino there is still one file, features/ArmClawIntake which you need to delete