search

XavierBerger / Solar-Router-for-ESPHome

Solar Router for ESPHome
GNU General Public License v3.0
9 stars 2 forks source link

change id of time #17

Open tikismoke opened 3 months ago

tikismoke commented 3 months ago

https://github.com/XavierBerger/Solar-Router-for-ESPHome/blob/22c3912fd9d19e2ae506fbb93b6e8a1131450b1b/solar_router/energy_saved_counter_theorical.yaml#L40

A lot of user use talready this id in common packages (with wifi and other stuff). Just rename the id to avoid duplicate and compilation issue please.

something like:

# Enable time component to reset energy at midnight
time:
  - platform: homeassistant
    id: homeassistant_time_for_solar_router
XavierBerger commented 3 months ago

Not sure that this id is published outside the solar router, but this is a good idea. I'll apply the proposed change like this, we will be 100% sure to avoid any possible conflict.

tikismoke commented 3 months ago

Id is not published, but as I have a common.yaml include for all my esp device containing common things (wifi/basic sensor/etc.) containing the same id (as a lot of other people because it's the one used in esphome doc) it failed to compile as we got 2 times the sames id in code.