XavierLiau34 / pe

0 stars 0 forks source link

Further elaboration of PIN section in DG may be required #7

Open XavierLiau34 opened 6 months ago

XavierLiau34 commented 6 months ago

image.png

Perhaps you may need to specify that a blank input is an invalid input for a pin in the DG, and a 6 digit pin is always required be it for creating a new pin or resetting the pin. I am aware of the disable pin option, but i am unaware that i cannot submit a blank input when i am asked to reset my pin, whereby in this scenario i expect the new pin to be nothing and i am expected to create a new pin again on each startup until i input a 6 digit pin.

nus-pe-bot commented 6 months ago

[IMPORTANT!: Please do not edit or reply to this comment using the GitHub UI. You can respond to it using CATcher during the next phase of the PE]

Team's Response

While this addition to the DG nice to have, it is not a need to have as it it self explanatory and does not justify being a bug. The notion that it should be a 6-digit PIN upon creation is given clearly in the DG and the application itself, and blank inputs(or any other invalid inputs) are appropriately handled in LongAh, so we do not consider the bug. We have classified it as not in scope as we do agree that it would be something to consider for future iterations in terms of documentation clarity.

The above explanation is also clearly shown in the below sequence diagram:

image.png

Or more succinctly,

image.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your reason]