search

XavierUniversity / V4

www.xavier.edu
1 stars 1 forks source link

Typography #13

Closed mcmullengreg closed 7 years ago

mcmullengreg commented 8 years ago

Need to identify the typography for Bands vs Content pages. Existing solution is to use class="subheader" to have better font sizing across content pages.

Another specific issue falls within the OL/UL font-weights.

JB may be able to assist in defining the typography itself across the board.

jordanbramel commented 8 years ago

I will sit down and really nail down the font sizes and weights for band & content pages this week.

mcmullengreg commented 8 years ago

@jordanbramel Let me know if you need assistance in setting something up to determine the base sizes. As of right now I've been using rem with 1rem = 10px. One of the accessibility issues (I'll open a new issue) is the lack of, or disorganization of headings on the banded pages. So this would be helpful to establish with that in mind.

PxToEm could prove useful in some of the sizing, but just keep in mind we'll be using REM.

mcmullengreg commented 7 years ago

@XavierUniversity/dev JB passed this to me for the heading typography. Seems like a good place to start. Thoughts?

Banded: http://www.xavier.edu/marketing-and-communications/test-2.cfm CS Template: http://www.xavier.edu/x-alumni/text.cfm

lieslandr commented 7 years ago

Seems OK to me. It looks like the headings get bolder as you move from h4-h6. Is that intentional?

lieslandr commented 7 years ago

Why are there two sets?

mcmullengreg commented 7 years ago

Original (Ologie) on top. Proposed on bottom (with the REM sizing on it).

lieslandr commented 7 years ago

Cool. Was I supposed to see that somewhere? I just want to make sure I am paying attention to the things I need to be paying attention to.

mcmullengreg commented 7 years ago

Don't think so. Probably should have mentioned that beforehand.

mcmullengreg commented 7 years ago

@jordanbramel Does this mean we're killing the subheader designation (at least for sizing). We can use that similar to the Muskie template and alter the color or something.

lieslandr commented 7 years ago

I wondered about that, too. I just came across a page that used it. I don't think it makes sense.

mcmullengreg commented 7 years ago

I've been using the subheader everywhere because the original font-sizing was so awful. If this remedies that, we should use it to actually call out a subheading. IMO

lieslandr commented 7 years ago

What is a subheading? Isn't that what the hierarchy is for in the first place?

mcmullengreg commented 7 years ago

For Ologie headers it reduced the font size. Which is the sole reason I used it on CS pages. CS (in the muskie template) only altered the color. From blue to grey (or something).

I'd say we could do something like that, instead of altering the font-size.

mcmullengreg commented 7 years ago

Remove the margin-top; keep margin bottom for CS headings only. Everything is good to go.