XavierUniversity / V4

www.xavier.edu
1 stars 1 forks source link

Button / Band naming conventions #27

Closed mcmullengreg closed 7 years ago

mcmullengreg commented 7 years ago

With the limited amount of colors (presumably). Should we consider modifying the names of our bands. Typical conventions are "primary, secondary, etc" instead of naming the color itself (navy, blue, etc).

Main rationale: If the "primary" color changes, the naming convention does not need to; just a color variable does.

This is not a blocking task.

jordanbramel commented 7 years ago

I'm fine with either, the rationale to changing them makes sense. As long as we have a kitchen sink somewhere as a guide - I'm okay with it.

lieslandr commented 7 years ago

What comes after 'secondary'? Do we have colors yet? It is safe to assume we will always have a blue-dark, blue-light, gray-dark, grey-light, and white?

lieslandr commented 7 years ago

Also, I forget how I am supposed to spell grey.

mcmullengreg commented 7 years ago

Sass has built in functions we could use for lighten or darken of any of the colors. Particularly the grey/white/black (not necessarily the blues). We can also rgba any of the sass vars for opacity (as needed).

@lieslandr Tertiary comes after secondary.

This would really apply to class names; not necessarily variable names, although it could.

lieslandr commented 7 years ago

I dig it. I think it makes sense to move in that direction.

mcmullengreg commented 7 years ago

Great. I'll continue down this path. And yes @jordanbramel we'll make sure we have some sort of documentation regarding these changes.

As of right now it'll be for bands and buttons. Could be extended into other elements.

Closing issue as we've resolved this for now.