XboxDev / extract-xiso

Xbox ISO Creation/Extraction utility. Imported from SourceForge.
http://sourceforge.net/projects/extract-xiso/
Other
706 stars 88 forks source link

Fix windows build (functionally and compilation) #3

Closed LukeUsher closed 6 years ago

LukeUsher commented 6 years ago

This PR updates the ancient Visual Studio solution so that it successfully compiles with Visual Studio 2017, as well as forcing little-endian mode when complied on issues. This fixes ISO creation/extraction on Windows.

LukeUsher commented 6 years ago

FTP support on Windows is still broken, but the important part (XISO creation/extraction) works.

JayFoxRox commented 6 years ago

Thanks for looking into this @LukeUsher !

The code is not perfect (it's a hack after all), but it's still better than master. So I'd be willing to accept this without changes - I'd still leave it for a couple of hours so @LukeUsher or any other @XboxDev maintainer can fix anything they want before merge.

Some random thoughts:

mborgerson commented 6 years ago

Thanks Luke! Before merging I'd prefer it if the endianness part is cleaned up (define it explicitly somewhere). Also I'd like the commits squashed into one, unless it makes sense to keep them apart.

Side notes: I agree w/ @JayFoxRox w.r.t. CMake and FTP. I think CMake is appropriate for this project--especially if we want to enable MSVS builds. FTP support should be dropped from this project. We should also introduce CI for this at some point since it's such a commonly used tool and people have been asking for builds.

LukeUsher commented 6 years ago

Any thoughts on this? I believe I addressed everything that was mentioned

mborgerson commented 6 years ago

Thanks Luke!