search

XboxDev / extract-xiso

Xbox ISO Creation/Extraction utility. Imported from SourceForge.
http://sourceforge.net/projects/extract-xiso/
Other
706 stars 88 forks source link

Improve License file. #40

Closed polarisfm closed 4 years ago

polarisfm commented 4 years ago

Remove the somewhat rambly LICENSE.txt in favor of a LICENSE file that simply contains the same modified BSD 3-clause license and more up-to-date copyright attribution.

GXTX commented 4 years ago

I have no thoughts on this but since you are changing something that gets included in the CI stuff can you also change it in .github/workflows/CI.yml, should be 3 lines to change. Would probably also be a good idea to change it in extract-xiso.c as well where it's much more rambly and includes a weird changelog.

LICENSE.TXT -> LICENSE

JayFoxRox commented 4 years ago

nit: Please remove trailing period from the commit messages for consistency with our git log.

Ideally squash commits and just call it something like "Cleanup license file"

JayFoxRox commented 4 years ago

Replaced by #41 (Reason: user is inexperienced with GitHub and probably didn't know that you can force-push to existing PRs; maybe also accidentally deleted their repository or branch).