search

XboxDev / nxdk-libcxx

Copy of libcxx git repository located at http://llvm.org/git/libcxx (adapted for original Xbox / nxdk toolchain)
http://libcxx.llvm.org
Other
4 stars 3 forks source link

XBox: Fix align_val_t in include/new #8

Closed glebm closed 2 years ago

glebm commented 2 years ago

Fixes https://github.com/XboxDev/nxdk/issues/587

glebm commented 2 years ago

This only fixes the declarations but there is nothing to actually link them against.

The built-in C++ aligned allocation is not defined:

lld: error: undefined symbol: void * __cdecl operator new(unsigned int, enum std::align_val_t)

Neither are _aligned_malloc and posix_memalloc.

glebm commented 2 years ago

Updated the patch.

It now works together with https://github.com/XboxDev/nxdk-pdclib/pull/52 and https://github.com/XboxDev/nxdk/pull/603 :tada:

glebm commented 2 years ago

@Ryzee119 This needs to be merged as well to fully enable aligned_alloc (and submodule needs to be bumped in nxdk)

thrimbor commented 2 years ago

Appears to work fine, merging