Update to current upstream PDCLib

XboxDev / nxdk-pdclib

The Public Domain C Library (adapted for original Xbox / nxdk toolchain)

http://pdclib.rootdirectory.de

Creative Commons Zero v1.0 Universal

19 stars 9 forks source link

Update to current upstream PDCLib #33

Closed dracc closed 3 years ago

dracc commented 4 years ago

Updates from 4f5b4339a48890599d8fb85bfa2fc6f031d47fe6 to 0b1e73807a0251ae62b208005fa0292992767199. Main changes are:

scanf fix (closes #16 )
memory leak in fclose fixed
asctime implementation
fwrite crash fix

Closes #28

JayFoxRox commented 4 years ago

The commits without prefix should probably be touched while we are rebasing anyway.

The reason why we didn't do the update yet, is because we also have to bring in changes from the upstream pdclib to our xbox platform folder. Did you do this properly? This means reviewing each commit and documenting the changes so we can re-apply them (including style-changes etc.).

We should probably also wait for #31 and #32 because when we rebase those PRs would be broken.

JayFoxRox commented 3 years ago

What's the status on this?

dracc commented 3 years ago

Updating the submodule was a bigger task than I anticipated and it turned out that I didn't have the skills nor time required to take care of it. Closing, hopefully someone with a more suitable skillset picks up the torch.