XboxDev / nxdk

The cross-platform, open-source SDK to develop for original Xbox: *new* xdk
437 stars 66 forks source link

Build containers only once and also do it for forks #656

Closed sharkwouter closed 12 months ago

sharkwouter commented 1 year ago

This PR changes the following:

What stays the same:

This is a first step towards a multi-step build using docker. I'd like to use that to be able to build packages which can be installed using a package manager I've been working on. I think this specific part is useful regardless of if that's the way you guys will want to go in the end, though.

thrimbor commented 12 months ago

I've read through all the changes as carefully as I could and they look good to me. I do think the commits should get consolidated before we merge though to get rid of fix-up commits. Squashing it all into a single commit would be fine imho.

sharkwouter commented 12 months ago

Thanks for the review @thrimbor! I've squished the commits into a single one now. Can you take another look? I've not made any other changes.