search

XboxUnity / AuroraScripts

Various LUA scripts for Aurora
33 stars 16 forks source link

SkinDownloader v2 #2

Closed DanielmGM closed 7 years ago

DanielmGM commented 7 years ago

New features, check the post in the forum

ThaMattie commented 7 years ago

Aurora only supports integer version numbers. Also, if you do not change the version number, it will not show an update message in repo browser. Please make it version 2 or something

DanielmGM commented 7 years ago

It works, the script has an automatic update checker in the hosting, the olny thing is that it doesnt ahow the .1 in the scripts list, but it doesnt matter

ThaMattie commented 7 years ago

I know it runs, but repobrowser will not get the new source unless you change the number, it has a caching mechanism. If you leave the number, people will download the old version and need to update right away. I will not approve the pull request with this version number.

DanielmGM commented 7 years ago

Done!

ThaMattie commented 7 years ago

there is something wrong with your linebreaks. it messes everything up in the repo browser

DanielmGM commented 7 years ago

It's charset is UTF8 without BOM, may be that?

ThaMattie commented 7 years ago

I don't know. the previous version was fine. You can check here on git, everything is on 1 line

DanielmGM commented 7 years ago

Yes, but it works, how's that aurorarepo cant read it? If it reads line by line for the "metadata" like the scriptTitle then i'll gonna put the metadata in single lines if you want