Console Info Viewer - Refactored/Ideas

[saywaking]

Basic Refactoring What i noticed, Code Review:

1.) We Could need simple functions for the Scripts like

• tableHasValue
• hasPermissions
• isDashboardCompatible 2.) PermissionsTable is only for information Purpose. We can still use all available API. 3.) When we do have Aurora 0.6+, we allways have all APIs, and we will always have CPU and GPU Key, so basically the check against nil is not necessary. 4.) I don't know if initializing/declaring variables is a high cost to the script Interpreter. You can tell me, if i should skip it or use minimum amount of variables. 5.) The MessageBox is too small and its height and weight is not variable. Also Text-Aligning in "output" of the Dialog is not possible due to the used Font i guess.

[ThaMattie]

1)

• tableHasValue can be implemented as you did fine
• see my comments on 2
• dashboard compatibility will be added in 0.7, it will not have to be checked by the script. Aurora will check it when it is defined 2) The permission table is a failsafe for people to accept to run a script or not. All the permissions that are defined are shown in the description. If a scripter tries to use something he didnt ask permission for the script will error out. I think this is enough. 4) it does not matter 5) this is the default msgbox. it is just a sample script. you can use the Gizmo to make your own scene (see weather script)

[saywaking]

Ok, thx for clarification I hoped for more global helper functions, but we can also do ot for ourselves. The main reason is because lua has some things missing like those or switch case for example, but yeah, that will be our problem

You missed my 3rd point. If we have Kernel Api permission, and its working, either we would have to check all its get-Functions against 'nil', or we don't. I assume we dont and i dont know why you checked dvd and cpu key certainly. I assume every console which runs Aurora is able to return its Keys. Either all or none. Maybe i miss something technically. You tell me.

This pull request was just intended for code review purposes. You can close it or merge the better aligned clean code. :)

[Swizzy]

CPU and DVD key both require dashlaunch in order to function... this means it'll return nil if you don't have them installed... (it's using the same functionality as i do in Simple 360 Nand Flasher)