Xbozon / rpg-styled-ui

Foundry VTT RPG Styled UI
12 stars 18 forks source link

High contrast option #63

Closed tamius-han closed 2 years ago

tamius-han commented 2 years ago

Hi. I'm really a fan of the look of this skin in general, but I have some minor complaints.

The theme seems a bit too dark with not enough contrast. This isn't a big problem when playing at night on a dark map, but under certain conditions, such as:

this theme's lack of contrast makes things a bit hard to read. Few examples:

The leftmost window, for comparison, is tidy5e with dark mode. Thanks to the higher contrast, text is significantly more readable there.

Similar thing applies to journal, where the paper is rather dark by default: slika

I feel that brighter background and brighter text would make the theme much more readable: slika

Sasmira commented 2 years ago

all time the same problem :D If you change something for one person, another person say that prefer the old version ...

There are no really solution ... you can fix yourself this problem with a fork, stay with author values or try another Ui ... I'm not saying this to be mean and do nothing about it, it's just a redundant question that has no real solutions ...

I say this from experience, because I have the same problem with Pathfinder Ui v3 which is a fork of RPG Styled Ui :)

Xbozon commented 2 years ago

@tamius-han I have to maintain a balance between visual quality and readability. Alas, the high contrast makes the interface not so attractive :(

I correct what I can, but it's difficult.

tamius-han commented 2 years ago

@Sasmira

There are no really solution ... you can fix yourself this problem with a fork,

Yes but without a proper defined license that's technically of questionable legality.

But doesn't hurt to ask so @Xbozon may I maintain a fork of this theme? (Even though I'll probably go slightly beyond merely upping the contrast a bit in mine)

Xbozon commented 2 years ago

@tamius-han

Yes, you can create forks quite freely. I would appreciate it if you could post a link to the original repository and author. I'm still on the lookout for a fairly proper license, but in this case let's go with fair use :)

tamius-han commented 2 years ago

Okay, thanks.

Xbozon commented 2 years ago

@tamius-han

I thought a little bit about the problem. It might be easier for you to release an addon that increases the contrast and install it as an additional mod. That way you'll get all the updates, but have your own changes.

Just enough to make a mod that imports another css file.

bearsy1 commented 2 years ago

@tamius-han

I like the idea of higher contrast + easier readability while maintaining most of the aesthetics from the original! I tried installing your forked version but I'm not sure if I did it right, or if things are working properly though.

I have the original module theme installed but it's not enabled in the settings, only the high contrast version is. Is this the correct way to use it?

As for comparing how it looks -- I can't tell if things have changed or if its changes are taking effect. Whether or not I enable the high contrast version, the original, or both at the same time, it doesn't seem to be visually different for me any of the ways I try it... not like the images you posted of your high contrast view. Any help/advice to get it looking like the third image you posted would be appreciated!