Xbozon / rpg-styled-ui

Foundry VTT RPG Styled UI
12 stars 11 forks source link

[Visual Improvement] White text on parchment not ideal #68

Closed tagnullde closed 3 months ago

tagnullde commented 1 year ago

Foundry: 10.286 System: 5e v2.0.3

The readability with the white text on the parchment background is not ideal. Is the a chance to make the text more readable?

image

Thank you for putting your module out there. It really enhanced my Curse of Strahd Campaign.

Sasmira commented 1 year ago

it's an option of Monk's little details ... you need to turn off this option

I have PR a new version of RPG Styled UI with Monks little details option turn off by default :)

tagnullde commented 1 year ago

That did it. Thanks for the tip. Shall I close this issue?

Sasmira commented 1 year ago

you can if it's good :)

tagnullde commented 1 year ago

Well, the white-text is still there.

I'll edit the issue and remove everything solved and let XBozon handle the rest.

Toastghost7 commented 1 year ago

I'm a bit confused, reading this. I don't even have Monks little details installed and i'm still getting the white text on parchment. Any other suggestions on how to fix it?

Sasmira commented 1 year ago

I'm a bit confused, reading this. I don't even have Monks little details installed and i'm still getting the white text on parchment. Any other suggestions on how to fix it?

Hello Hello,

S. :)

Toastghost7 commented 1 year ago

Gladly! Thanks for taking the time.

Foundry version: Version 10, build 291. D&D5E Version 2.0.3 Styled UI version is on 1.1.0

And it looks like this: Example

Xbozon commented 1 year ago

@Toastghost7

I plan to release a patch this coming weekend (I'm already working on it). It will include a fix for this problem.

Thanks for the additional screenshots!

P.S. @Sasmira I'll take your list of questions for the Issue template :)

Toastghost7 commented 1 year ago

Great to hear! Looking forward to it. Thanks for the hard work, as always!

Xbozon commented 1 year ago

@Toastghost7 I fixed this in v1.1.1, try it!

Toastghost7 commented 1 year ago

@Xbozon

Thanks so much! Looks really good, much more readable. My only critique would be, heading 2 under heading 1 looks a little worse now, it looks like everything is highlighted all at once, if that makes sense. Might be nicer if only Heading 1 glows with a red border, like with this quick example I made. Left is how it currently looks, right is a rough example of how it might look without the glow on heading 2. EDIT also noticing that because of this, it doesn't get that nice "Highlight" effect when you mouse over the text/table of contents, no matter what heading size it's at.

SCuffed_Example

Xbozon commented 1 year ago

@tagnullde Yes, it's a bug, it's strange that I didn't find it. I'll try to fix it soon.

Bernie-McGee commented 5 months ago

Should this be reopened for chat readability? Or should I submit a new issue?

*edit - I have a game to run tonight, but late tonight or this Saturday I will load up a test world with no other mods to confirm that's not the problem.

readability

Sasmira commented 5 months ago

Hello Hello,

Bernie-McGee commented 4 months ago

Weird, I could swear I responded the other night. But it was super late, maybe I forgot to submit the comment. Sorry for the delay!!

Sasmira commented 4 months ago

no worries, it happens to the best of us too :D I'll see on my side as soon as possible, but I can't guarantee anything ... I don't play DD5 but I do a bit of maintenance on the ui.

Xbozon commented 4 months ago

I'm here too, but won't be able to fix it in the next week :(

Sasmira commented 4 months ago

I'm here too, but won't be able to fix it in the next week :(

he is alive :D

Bernie-McGee commented 4 months ago

No problem, I have a workaround using Lib Themer.

Thanks for the amazing theme (for free to boot!).

If there's anything I can do to help testing wise, let me know. Happy to help.

Sasmira commented 4 months ago

No problem, I have a workaround using Lib Themer.

Thanks for the amazing theme (for free to boot!).

If there's anything I can do to help testing wise, let me know. Happy to help.

I send you a MP on discord if you want expose me your problems

Sasmira commented 4 months ago

ok PR done https://github.com/Xbozon/rpg-styled-ui/pull/91