search

Xbozon / storyteller

A small modification that allows you to present the story in the game as an open book.
Apache License 2.0
16 stars 9 forks source link

please consider #39

Closed Benjaneer closed 1 year ago

Benjaneer commented 1 year ago

Screenshot_2022-09-06_20_48_25 Screenshot_2022-09-06_20_47_56 Screenshot_2022-09-06_20_45_32 Screenshot_2022-09-06_20_45_00

Benjaneer commented 1 year ago

also added page turning tabs in the lower corners, they lookup the entry name and append a "1" or add 1 for next page and subtract or remove the number for previous

https://user-images.githubusercontent.com/9536408/189500642-53bed396-098c-4dd8-a590-51c3f268ddcd.mp4

Note: the next/previous pages will show regardless of permissions

Xbozon commented 1 year ago

@Benjaneer

Thank you very much for your work, but I have to finish with the fixes for v10 first :( So far, I can't fix the problem that when you create a journal, it is created with the standard type, instead of a new one.

Benjaneer commented 1 year ago

added a book cover, text on top of image (maybe difficult/impossible to change image while in this style though), invisible page-turn tabs are also still in the corners Screenshot_2022-09-24_19-39-27

Benjaneer commented 1 year ago

I still haven't patched to v10 or I'd try to help with that.

Xbozon commented 1 year ago

@Benjaneer Hello, I have finished the basic changes for v10, however they are not compatible with this MR. From the good news, focusing on your MR, I was able to recreate some of the features you need. I suggest waiting for the v10 release and then see what is missing. Okay?

Benjaneer commented 1 year ago

np, I've been thinking I'll just stick with v9, but feel free to use or cannibalize as much or as little as you like from the MR.

Xbozon commented 1 year ago

Thanks for taking the time to PR, but for a better experience with custom journals, I've added an API, I'd love for you to check it out and take advantage of it.

https://github.com/Xbozon/storyteller-addon-example

I'm open to any questions.

Benjaneer commented 1 year ago

That page turn is exquisite. I can see you're still hammering out the alignment and stuff, but I love it. image

Xbozon commented 1 year ago

@Benjaneer

I sometimes catch this bug in turn.js (third-party library), so far I can't fix it. It occurs mostly if you use foundry as a separate program, not in the browser.

Do you have a different situation?

Benjaneer commented 1 year ago

that is how I use it, I also noticed that it only happens on page2 lower left corner (turning from bottom to table of contents)

Benjaneer commented 1 year ago

I've also noticed that my page editor doesn't look like you have pictured in the readme