search

Xbozon / storyteller

A small modification that allows you to present the story in the game as an open book.
Apache License 2.0
16 stars 9 forks source link

Change CONFIG.debug to boolean breaks a lot of modules #46

Closed MrPrimate closed 1 year ago

MrPrimate commented 1 year ago

You set CONFIG.debug = true at https://github.com/Xbozon/storyteller/blob/main/main.js#L3

CONFIG.debug is an object, changing it to a bool breaks a lot of modules that add their own debug settings here. Use a key within this object instead.

You also, probably don't want to be shipping debug set to true in a module.

kaelad02 commented 1 year ago

I wouldn't be surprised if this is the underlying cause of #44

Xbozon commented 1 year ago

@MrPrimate I really apologize for this silly mistake, I was ending up very tired and forgot to put away the debugging. Thanks for creating the issue!

Fixed in v1.0.1