Xbozon / storyteller

A small modification that allows you to present the story in the game as an open book.
Apache License 2.0
16 stars 9 forks source link

Journal opens for everyone that has permissions anytime any edit it's made to its contents #47

Open Yx2xY opened 1 year ago

Yx2xY commented 1 year ago

Hey first of all, thanks for this awesome module!

Wanted to report that, as the title says, anytime an edit its made to the storyteller journal the journal opens to anyone with any level of viewing permissions.

it's specially troublesome when trying to add info in secret.

Xbozon commented 1 year ago

@Yx2xY I checked the behavior. In my case, there is sound when editing, but the book does not open for other players. This may be complicated, but could you please record a video so I can understand the problem?

Yx2xY commented 1 year ago

Sure, here's the video.

https://user-images.githubusercontent.com/24735623/196848622-25d96d70-1340-4d51-9cb6-571b7675f8b1.mp4

Something that it's no shown there, when the GM shows a Storyteller journal to the players without any type of permissions from that point forward anytime the GM edits the journal it opens as a blank Storyteller journal to the players that don't have own/limited/observer permissions similar as in the video, and when the owner player edits it, it opens the entire journal for the other players.

Sorry for the brightness changes, Windows HDR is all messed up.

Another small thing that I noticed, the index doesn't work, when clicked on any numeral it does not open the page.

Xbozon commented 1 year ago

Is only the storyteller mod enabled in the video?

Yx2xY commented 1 year ago

That is correct I tested it without modules enabled, for the purposes of the video I did not disable modules because it was easily reproducible, you just need to first "show to the players" the journal and then every time you add a page or edit one it opens up the journal to the other players

Edit: video for confirmation

https://user-images.githubusercontent.com/24735623/197000510-af1405eb-625a-48dd-8086-6edf2b91cf6e.mp4

Xbozon commented 1 year ago

I am very sorry for the long response. I have tried several times to reproduce the problem, but the behavior remains normal. Whenever editing, the history show trigger did not work.

Can you update to the latest versions of Foundy and modules, and check again?

Thanks for using the mod!

Yx2xY commented 1 year ago

Hi there! Don't worry about it we all have limited time during our days and I appreciate you taking the time to look into this, I'll update the module later today and will give it a try.

Thanks for all your hard work!