search

Xceptance / neodymium-library

A test automation library based on common other best practice open source libraries. It adds missing functionalities but does not reinvent the wheel. Just glues stuff together nicely and adds some sprinkles.
MIT License
80 stars 11 forks source link

Remove Guava dependency #131

Closed occupant23 closed 4 years ago

occupant23 commented 4 years ago

The guava dependency: com.google.guava is only used in one place and this code can easily replaced by using streams.

occupant23 commented 4 years ago

@oomelianchuk Please recheck.

oomelianchuk commented 4 years ago

Hurra! We have one dependency less on the project and used Java 8 instead. That's wonderful!

h-arlt commented 4 years ago

Unfortunately, Guava is not completely gone. It is still a transitive dependency of browserup-proxy-core.

occupant23 commented 4 years ago

That's okay. I just wanted to remove the explicit dependency due to one line of code.

h-arlt commented 4 years ago

Totally right.