search

Xceptance / neodymium-library

A test automation library based on common other best practice open source libraries. It adds missing functionalities but does not reinvent the wheel. Just glues stuff together nicely and adds some sprinkles.
MIT License
80 stars 11 forks source link

Deprecate SelenideAddons.matchAttribute #146

Closed occupant23 closed 3 years ago

occupant23 commented 3 years ago

Deprecate the SelenideAddons.matchAttribute function since com.codeborne.selenide.Condition.attributeMatching does a similar job.

occupant23 commented 3 years ago

Ready to recheck. I also exchanged an example function in the wiki to showcase another supported function instead.

h-arlt commented 3 years ago

Please see my comments on your commit.

occupant23 commented 3 years ago

Fixed them. Please review again.

h-arlt commented 3 years ago

Looks good to me.