search

Xceptance / neodymium-library

A test automation library based on common other best practice open source libraries. It adds missing functionalities but does not reinvent the wheel. Just glues stuff together nicely and adds some sprinkles.
MIT License
80 stars 11 forks source link

Create a function to stabilize test that are flaky due to page features that are not relevant for the test #148

Closed occupant23 closed 3 months ago

occupant23 commented 3 years ago

I noticed, that the code like this

        try
        {
            $("#onetrust-accept-btn-handler").shouldBe(visible);
        }
        catch (ElementNotFound e)
        {
            overlayIsVisible = false;
        }

is/can be used in multiple projects, e.g. I built a custom method like this for a customer project. Wouldn't it be a good idea to extend SelenideAddons with methods to wait until or while some condition, without any exception throwing but just returning a boolean value as information whether the condition was fulfilled?

_Originally posted by @oomelianchuk in https://github.com/Xceptance/neodymium-library/issue_comments/703550134_

occupant23 commented 3 years ago

@georgkunze Have you already added documentation regarding this feature to our wiki dev branch?

georgkunze commented 3 years ago

@georgkunze Have you already added documentation regarding this feature to our wiki dev branch?

I just checked. And there is no added documentatio for this feature.

occupant23 commented 3 years ago

Documentation needs to be added, Issue is ready for final test

AJakobi commented 4 months ago

Added docu, ready for review