search

XcodesOrg / XcodesApp

The easiest way to install and switch between multiple versions of Xcode - with a mouse click.
MIT License
6.83k stars 296 forks source link

Button color change on row select. #109

Open Kamik423 opened 3 years ago

Kamik423 commented 3 years ago

When using arrow keys to select a row the blue (OPEN) button will immediately turn white. But using the mouse will have a short lag which looks suboptimal and weird.

EDIT: Additionally it also looks a bit confusing how blue and white buttons are white when selected. I guess this should somehow be changed, too.

https://user-images.githubusercontent.com/16278233/108609160-692cd300-73cc-11eb-9989-1eb41371cd96.mov

Version

interstateone commented 3 years ago

Thanks @Kamik423, this was another SwiftUI.List thing that I wasn't able to figure out. The way selection behaves in NSTableView is generally "nicer", and for some reason when I tried to replicate the color updating, the SwiftUI.List selection state is updated on mouse up instead of mouse down. Like #96, I'd be curious to see if there's a way to achieve better behaviour while continuing to use SwiftUI.List, but this might have to wait for an improvement in the framework.

Additionally it also looks a bit confusing how blue and white buttons are white when selected. I guess this should somehow be changed, too.

If you feel strongly about this can you please open a separate ticket and elaborate on what you'd prefer to see instead?