search

XcodesOrg / XcodesApp

The easiest way to install and switch between multiple versions of Xcode - with a mouse click.
MIT License
6.61k stars 291 forks source link

Resolve content clipping inside Xcode detail view #539

Closed LiYanan2004 closed 3 months ago

LiYanan2004 commented 3 months ago

Problems

Inside Xcode's detail view, I noticed there is a hard clip, which is annoying to me 🤣.

Fix

Replace padding with contentPadding (custom modifier using safeArea) to avoid ScrollView's clipping.

Comparison

https://github.com/XcodesOrg/XcodesApp/assets/37542129/8151dc34-858f-428f-bd27-1f4abfd57f01

Much better.

LiYanan2004 commented 3 months ago

Not sure why the tests are failed. Seems to be okay.

MattKiazyk commented 3 months ago

@LiYanan2004 thanks for your work on this. https://github.com/XcodesOrg/XcodesApp/pull/540 implements the same margin fixes and includes others, so i'm going to merge that one it.

Thanks again!

LiYanan2004 commented 3 months ago

@MattKiazyk Looks good. But older OS deserves this margin as well because technically it's possible. So I implemented it again. Please check it out😁