search

XcodesOrg / XcodesApp

The easiest way to install and switch between multiple versions of Xcode - with a mouse click.
MIT License
6.61k stars 291 forks source link

Fix broken DockProgress Bar #545

Closed Kyle-Ye closed 6 days ago

Kyle-Ye commented 3 months ago

Close #529 and #491

MattKiazyk commented 1 month ago

I tried this PR originally and it didn't fix it (for me anyway). Added https://github.com/XcodesOrg/XcodesApp/pull/545/commits/33dc6347f2eb1fa573e9395450bdc040021eefa6 @Kyle-Ye to make sure we reset after we're all done.

Most likely after v2 came out something changed in order and this was missed. Let me know if that works for you?

Kyle-Ye commented 1 month ago

I tried this PR originally and it didn't fix it (for me anyway). Added 33dc634 @Kyle-Ye to make sure we reset after we're all done.

Most likely after v2 came out something changed in order and this was missed. Let me know if that works for you?

When I test my PR locally, I'll always hit helperInstallState != .installed.

https://github.com/XcodesOrg/XcodesApp/blob/4a4b469e3f56af370f7d9b07fc263a57495d8f8d/Xcodes/Backend/AppState%2BInstall.swift#L432

That may explain why it didn't fix the issue for you.

After reviewing your change, it looks fine and I was wondering should we remove Line 432 on AppState+Install.swift after your change. @MattKiazyk