Expand .xip on the destination volume

juanjonol commented 2 years ago

After PR #126, xcode install supports a custom path for Xcode's installation, but this path isn't directly used for the .xip expansion, using instead the same directory where it’s downloaded (~/Library/Application Support/com.robotsandpencils.xcodes/)[^1]. If this custom installation path is to a different volume than the .xip, this means that:

Xcode.app must be first expanded and then moved to another volume, a relatively slow operation given its massive size.
This installation requires double the free space than on a same-volume installation, because Xcode is first copied to the destination volume and only when it has finished it’s deleted from the original volume.

So I think it makes sense to expand the .xip directly on the final volume where Xcode will be installed (probably on the /.TemporaryItems folder).

Would you accept a pull request for this? Thank you!

[^1]: I assume this is done to avoid having a partial Xcode installation on the destination folder, which sounds reasonable to me.

MattKiazyk commented 2 years ago

@juanjonol absolutely accept a PR for this.

Did something similar with Xcode.app - if you could follow the similar pattern that would be 💯

https://github.com/RobotsAndPencils/XcodesApp/pull/155/files

juanjonol commented 1 year ago

Sorry to bother you @MattKiazyk, but the PR #179 that closes this has been ready for months. It says that some changes are required, but I made those changes a long time ago. Maybe you've missed this PR because it still says that there're changes requested?

XcodesOrg / xcodes

Expand .xip on the destination volume #178